-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(firestore): options to include document ID on valueChanges() #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore): options to include document ID on valueChanges() #2113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Will merge once ready to cut 5.3
This is very important feature, thank you |
I think this does not work if you call it on a collection instead of a document |
This is what I had to do to make it work on a collection. Perhaps there is better way, but this is my first week with rxjs:
|
Are there any updates to this PR? It's been a while since release 5.3. |
Whoops, meant to get this into 5.3 but working on 6 ate up all my time. Will get this into 6.1. |
Can this be added to 6.0.4? |
New API so had to wait for a minor, will aim to get this in today for |
Checklist
valueChanges()
when reading a single document #2109yarn install
,yarn test
run successfully? YesDescription
Continuation of #1976 - added
idField
option fordocument.valuChanges()
to include the document ID on the emitted data payload. Updated documentation for this one and added some missing changes from the previous PR.Code sample